Fully new cleanup service #811
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponyisi
reviewed
Jul 16, 2024
| else: | ||
| use_https = strtobool(os.environ['MINIO_ENCRYPT']) | ||
| if 'S3_ENCRYPT' in os.environ: | ||
| if isinstance(os.environ['S3_ENCRYPT'], bool): |
There was a problem hiding this comment.
can this ever be bool? shouldn't os.environ only ever have strings?
ponyisi
reviewed
Jul 16, 2024
| datasets = self.get_datasets() | ||
| self.logger.info('datasets in servicex db', extra={"datasets": len(datasets)}) | ||
|
|
||
| # delete datasets not used recently |
There was a problem hiding this comment.
Is there a possible race condition here? (between lookup of datasets and deletion, a job starts and requests the dataset that is about to be cleaned?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans both S3 and the database.